Switch atomic.Value to atomic.Pointer for spanProcessorStates #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared and
hanyuancheung
as code owners
pellared
reviewed
Mar 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3926 +/- ##
=====================================
Coverage 81.8% 81.8%
=====================================
Files 170 170
Lines 12911 12911
=====================================
Hits 10563 10563
Misses 2129 2129
Partials 219 219
|
|
Is there any performance difference? |
|
There is zero performance difference based on the existing benchmark tests. |
pellared
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
I am OK with the PR, but TBH I am not sure if it is worth addressing globally.
Personally, I see almost no value. Someone needs to write the code, then others need to review and a maintainer needs to merge 😉
However, for sure it would be OK to use atomic.Pointer in "new codebase" or during refactoring. Finally, it is very good to know that there are no performance differences.
|
I agree, there is null value in doing this everywhere. I did it in the tracer as a quick one to start looking at the related issue. But I don't think we should apply the principle in other places. |
hanyuancheung
approved these changes
Mar 25, 2023
MrAlias
approved these changes
Mar 27, 2023
This was referenced Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first look at switching
atomic.Valuetoatomic.Pointer, so we have better type safety, and supposedly better readability.I'm saying "supposedly" for better readability because for this specific case, it requires doing a lot of going from pointer to value, as a slice type can't be used from its pointer.
See #3918.